Re: [xen-devel][RFC] xl disk configuration handling

[Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>]

>>> do we really need to change the parsing function that much? I
>>> understand there are significant changes but this is a total rewrite.
>>> I am concerned about all the bugs we might find later after the
>>> release...
>>>
>> This is one change I would really like to go with.  Not only does it help 
>> with
>> the changes we needed, it also gets rid of code duplication.  With this 
>> change
>> block-attach can rely on the same parsing code (that is once I submit the
>> block-attach changes patch).
>  
> It took us several iterations to get the parsing right, I would like to
> keep the state machine and the field parsing as it is, but each case
> could have its own function to implement it.  In other words, would you
> be OK with calling parse_disk_attrib, parse_disk_vdev_info and
> parse_disk_pdev_info from the main switch under DSTATE_PHYSPATH,
> DSTATE_VIRTPATH, etc?

Sure, I will go with appropriate DSTATE_* for each chunk we parse.

Kamala


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel