Re: [Xen-devel] Three small patches for xen-4.1.0-rc

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2011-01-31 at 22:37 +0000, M A Young wrote:
> Here are three small patches that I have applied to the Fedora xen builds 
> and I think are are suitable for xen-4.1.0.

Thanks, I general we would prefer separate patches to be submitted
separately rather than bundled in a single submission ("hg email" can
help with this for large series).

In particular having independent changelogs in a form where they can be
used directly (e.g. a good firstl ine summary and without references to
the "first patch" etc) is much appreciated.

> The first patch fixes an anomaly in /etc/xen/scripts/network-route. 
> Currently this script contains
> netdev=${netdev:-eth${vifnum}}
> ie. netdev is set to eth${vifnum} by default. Unfortunately vifnum is not 
> set anywhere in the xen code so the default is actually the broken "eth". 
> The patch changes the default to eth0 (which is what the comment at the 
> top of the file says it should be).

The comment also refers to an antispoof setting which I don't see being
implemented here. Is that just a wrong comment? (possibly cut and paste
error from one of the other network-*)

> The next patch updates a comment about NetworkManager not supporting 
> bridging in Fedora 11 to refer instead to Fedora 14.

Was the NetworkManager stuff introduced in 14 and erroneously documented
as being in 11, or was it in 11 and worked fine, or has it been
continuously broken since F11? IOW should this comment refer to breakage
in Fedora 11 thru 14 or something similar?

> The final patch solve a build problem in Fedora rawhide, where rpm (4.9.0) 
> doesn't automatically supply a "provides" entry for a library unless it is 
> executable. This patch makes the libvhd and libblktap library files 
> executable (and consistent with the other libraries in xen) so that rpm 
> generates the right "provides" entries and therefore does the right thing 
> when resolving package dependencies.

Ick, but apparently normal.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel