Re: [Xen-devel] [PATCH] xensec_tool: Fix for xc_interface_open() call

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2011-01-27 at 16:12 +0000, Daniel Kiper wrote: 
> Hi,
> 
> xc_interface_open() was called with improper number
> of arguments. It is fixed by this patch.
> 
> Daniel
> 
> # HG changeset patch
> # User dkiper@xxxxxxxxxxxx
> # Date 1296143465 -3600
> # Node ID 18f67003e804d4774fa27ddfd16177cc15538b7b
> # Parent  003acf02d416d657f750b7a7748fa8c5a932222c
> xc_interface_open() was called with improper number
> of arguments. It is fixed by this patch.
> 
> Signed-off-by: Daniel Kiper <dkiper@xxxxxxxxxxxx>

Appears to have been missed by 21483:779c0ef9682c. The interface change
also included the return type (int->xc_interface *) but that was already
covered in 21483.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> diff -r 003acf02d416 -r 18f67003e804 tools/security/secpol_tool.c
> --- a/tools/security/secpol_tool.c    Thu Jan 20 17:04:06 2011 +0000
> +++ b/tools/security/secpol_tool.c    Thu Jan 27 16:51:05 2011 +0100
> @@ -511,7 +511,7 @@ int main(int argc, char **argv)
>          if (argc != 2)
>              usage(argv[0]);
>  
> -        if ((xc_handle = xc_interface_open()) == 0) {
> +        if ((xc_handle = xc_interface_open(0, 0, 0)) == 0) {
>              printf("ERROR: Could not open xen privcmd device!\n");
>              exit(-1);
>          }
> @@ -523,7 +523,7 @@ int main(int argc, char **argv)
>          if (argc != 3)
>              usage(argv[0]);
>  
> -        if ((xc_handle = xc_interface_open()) == 0) {
> +        if ((xc_handle = xc_interface_open(0, 0, 0)) == 0) {
>              printf("ERROR: Could not open xen privcmd device!\n");
>              exit(-1);
>          }
> @@ -535,7 +535,7 @@ int main(int argc, char **argv)
>          if (argc != 2)
>              usage(argv[0]);
>  
> -        if ((xc_handle = xc_interface_open()) == 0) {
> +        if ((xc_handle = xc_interface_open(0, 0, 0)) == 0) {
>              printf("ERROR: Could not open xen privcmd device!\n");
>              exit(-1);
>          }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel