Re: [Xen-devel] Re: pvusb drivers for pvops 2.6.32.x kernel

[Nathanael Rensen <nathanael@xxxxxxxxxxxxxxxx>]

On 7 January 2011 02:55, Pasi Kärkkäinen <pasik@xxxxxx> wrote:

> Something I noticed about the pvusb backend..
> Should the name of the driver be xen-usbbk instead of just usbbk ?
>
> The other backend driver modules seem to have xen- prefix.
>
> -- Pasi

Good point - although I think xen-usbback would better match
xen-blkback, xen-netback, xen-pciback.

For consistency the config options should probably be
CONFIG_XEN_USBDEV_BACKEND and CONFIG_XEN_USBDEV_FRONTEND (the previous
patch had CONFIG_XEN_USB_...).

I also noticed the frontend driver was producing a warning when
loading which is resolved by setting the module owner.

I've placed an updated diff here:
http://members.iinet.net.au/~nathanael/pvusb.diff

Nathanael

Attachment: pvusb2.diff
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel