[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] Re: [PATCH] infiniband/mthca : Fix userland mapping of mthca infiniband cards in Xen dom0
> > Finally as a stylistic thing I would probably prefer to see the > > vm_page_prot manipulation written as > > > > Â Â Â Âvma->vm_page_prot = > > pgprot_noncached(vm_get_page_prot(vma->vm_flags)); > > > > Makes sense. > While digging, I've also seen things like : > > vma->vm_page_prot = pgprot_noncached(vm_get_page_prot(vma->vm_flags | > VM_IO)); This isn't the same, since it doesn't set VM_IO in vm_flags. > > wrapped up in a helper function; presumably every instance of > > > > Â Â Â Âvma->vm_page_prot = pgprot_FOO(vma->vm_page_prot) > > > > under drivers/ would need the same fix for Xen. > > The issue is actually only related to mappings of bus memory to > userland. In kernel space, ioremap() is generaly used, which I > understand sets the _PAGE_IOMAP flag. Right, but setting vm_page_prot means a driver is doing userspace mapping of something, and if it's setting pgprot, that would generally mean it's not mapping RAM. - R. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |