Re: [Xen-devel] regression from c/s 22071:c5aed2e049bc (ept: Put locks around ept_get_entry) ?

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Dec 16, Keir Fraser wrote:

> Excellent. I will lay groundwork and fix pte_{read,write}_atomic directly in
> -unstable and -4.0-testing. I will then post a proposed fix for EPT to the
> list. I don't know that code so well and I may not otherwise catch all
> places that require use of the new accessor macros.

Keir,

this failure may be related to the changes that went just into
xen-unstable, fails in openSuSE 11.2 and 11.3 on 32bit:

make[2]:âEnteringâdirectoryâ
`/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/arch/x86'
gccâ-fomit-frame-pointerâ-fmessage-length=0â-O2â-Wallâ -D_FORTIFY_SOURCE=2â
-fstack-protectorâ-funwind-tablesâ -fasynchronous-unwind-tablesâ-O1â
-fno-omit-frame-pointerâ -fno-optimize-sibling-callsâ-m32â-march=i686â-gâ
-fno-strict-aliasingâ -std=gnu99â-Wallâ-Wstrict-prototypesâ-Wno-unused-valueâ 
-Wdeclaration-after-statementââ-nostdincâ-fno-builtinâ-fno-commonâ 
-Wredundant-declsâ-iwithprefixâincludeâ-Werrorâ-Wno-pointer-arithâ-pipeâ 
-I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/includeââ 
-I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm-x86/mach-generic
 â 
-I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm-x86/mach-default
 â-msoft-floatâ-fno-stack-protectorâ-fno-exceptionsâ-gâ-D__XEN__â -DVERBOSEâ
-DCRASH_DEBUGâ-fno-omit-frame-pointerâ-DCONFIG_FRAME_POINTERâ 
-DMAX_PHYS_CPUS=32â-MMDâ-MFâ.xen.dâ-O1â-fno-omit-frame-pointerâ 
-fno-optimize-sibling-callsâ-m32â-march=i686â-gâ-fno-strict-aliasingâ 
-std=gnu99â-Wallâ-Wstrict-prototypesâ-Wno-unused-valueâ 
-Wdeclaration-after-statementââ-nostdincâ-fno-builtinâ-fno-commonâ 
-Wredundant-declsâ-iwithprefixâincludeâ-Werrorâ-Wno-pointer-arithâ-pipeâ 
-I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/includeââ 
-I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm-x86/mach-generic
 â 
-I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm-x86/mach-default
 â-msoft-floatâ-fno-stack-protectorâ-fno-exceptionsâ-gâ-D__XEN__â -DVERBOSEâ
-DCRASH_DEBUGâ-fno-omit-frame-pointerâ-DCONFIG_FRAME_POINTERâ 
-DMAX_PHYS_CPUS=32â-MMDâ-MFâ.asm-offsets.s.dâ-Sâ-oâasm-offsets.sâ 
x86_32/asm-offsets.c
cc1:âwarningsâbeingâtreatedâasâerrors
Inâfileâincludedâfromâ
/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm/spinlock.h:6,
âââââââââââââââââfromâ
/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/xen/spinlock.h:6,
âââââââââââââââââfromâ
/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/xen/sched.h:7,
âââââââââââââââââfromâx86_32/asm-offsets.c:9:
/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm/atomic.h:âInâ
functionâ'atomic_write64':
/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm/atomic.h:39:â
error:âoperationâonâ'old'âmayâbeâundefined
make[2]:â***â[asm-offsets.s]âErrorâ1
make[2]:âLeavingâdirectoryâ
`/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/arch/x86'

 36 static inline void atomic_write64(volatile uint64_t *addr, uint64_t val)
 37 {
 38     uint64_t old = *addr, new, *__addr = (uint64_t *)addr;
 39     while ( (old = __cmpxchg8b(__addr, old, val)) != old )
 40         old = new;
 41 }


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel