[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] RE: [RFC][PATCH][VTD] EPT/VT-d page table sharing
Hi Tim, Thanks for your feedback. In attached updated patch, I have: 1) moved setting of iommu_hap_pt_share flag to init_vtd_hw(). This function initialized other vt-d specific features. Let me know if you know of a better place. 2) rename avail2 field to sa_p2mt. Let me know if you have any additional comments. Allen -----Original Message----- From: Tim Deegan [mailto:Tim.Deegan@xxxxxxxxxx] Sent: Thursday, December 09, 2010 2:13 AM To: Kay, Allen M Cc: Wei Wang2; Keir Fraser; Han, Weidong; xen-devel@xxxxxxxxxxxxxxxxxxx Subject: Re: [RFC][PATCH][VTD] EPT/VT-d page table sharing At 18:38 +0000 on 08 Dec (1291833518), Kay, Allen M wrote: > Attached is EPT/VT-d page table sharing patch I mentioned earlier. Basic > idea is to leverage 2MB and 1GB page size support in EPT by having VT-d using > the same page tables as EPT. When EPT page table changes, flush VT-d IOTLB > cache. > > We are still further testing this patch but would appreciate feedbacks. Looks good! Two minor nits: - the path through iommu_set_pgd where the feature gets turned on is a bit confusing. It would be cleaner to have the global flag enabled as part of the general machine init. - while you're moving the p2m bits into avail2, could you rename the avail2 field to p2mt or similar? It would make the rest of the code clearer. Cheers, Tim. > Signed-off-by: Weidong Han <weidong.han@xxxxxxxxx> > Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx> -- Tim Deegan <Tim.Deegan@xxxxxxxxxx> Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) Attachment:
share1210.patch _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |