[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 1 of 4] Support getting topology info in libxl
- To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
- From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
- Date: Wed, 08 Dec 2010 13:01:43 +0100
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 08 Dec 2010 04:05:32 -0800
- Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=gnD6uuDBl0GBLc1QJRa0yBWxlHX4yJswIBwXnHY20kaE6DwqDhnJaOwY SwvogAfUBBg5EpF+dx86Agc3Z2a5zNdVrSGcYkXPnhphHKJr/u4+SqP2Y XLAfc0kdpfuI71WPqVdMppA8w/SESd0Ioi95aV+3WXK2e5QjpYO8apebn d3UqmdFWXgdGKn3Br/eQX6NEgOQGlOmMW+qXtUi9sRS+S5YUM3jNaeBcL pz0iQifGqDP5A03h+dVzDlXqETn1U;
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
On 12/08/10 11:51, Ian Campbell wrote:
On Fri, 2010-11-26 at 07:10 +0000, Juergen Gross wrote:
diff -r 79b71c77907b -r 37fdfe90e0c2 tools/libxl/libxl.h
--- a/tools/libxl/libxl.h Wed Nov 24 10:20:03 2010 +0000
+++ b/tools/libxl/libxl.h Thu Nov 25 09:29:43 2010 +0100
@@ -148,6 +148,13 @@
uint8_t *map;
} libxl_cpumap;
void libxl_cpumap_destroy(libxl_cpumap *map);
+
+typedef struct {
+ uint32_t entries;
+ uint32_t *array;
+} libxl_cpuarray;
+#define LIBXL_CPUARRAY_INVENTRY ~0
This looked at first glance like you had misspelled INVENTORY. Perhaps
LIBXL_CPUARRAY_INVALID_ENTRY?
Okay, I don't mind.
+void libxl_cpuarray_destroy(libxl_cpuarray *array);
typedef enum {
XENFV = 1,
@@ -464,6 +471,7 @@
int libxl_button_press(libxl_ctx *ctx, uint32_t domid, libxl_button button);
int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo);
+libxl_topologyinfo *libxl_get_topologyinfo(libxl_ctx *ctx);
The idiom in libxl is for such functions to take a pointer to the
structure to fill in and return a status code, e.g.
int libxl_get_topologyinfo(libxl_ctx *ctx, libxl_topologyinfo *info)
e..g libxl_get_physinfo()
This is useful since the caller doesn't always need to manage the
dynamic allocation of the info structure e.g, it can use a stack
variable for temporary stuff or nest inside another structure etc.
I'll change it.
Juergen
--
Juergen Gross Principal Developer Operating Systems
TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28 Internet: ts.fujitsu.com
D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
