Re: [Xen-devel] Re: how to handle paged hypercall args?

[Keir Fraser <keir@xxxxxxx>]

On 03/12/2010 01:06, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

>> I didn't look in detail whether that's being done in a non-intuitive
>> way elsewhere, but I can't see how the event you're waiting on
>> would ever get signaled - wouldn't you need to pass it into
>> __hvm_copy() and further down from there?
> 
> I was relying on the kind-of wakeup in p2m_mem_paging_resume().
> 
> There will be a new patch shortly.

vcpu_pause() is nestable and counted. So the vcpu_unpause() on
MEM_EVENT_FLAG_VCPU_PAUSED will not be enough to wake up a vcpu that is also
paused on a waitqueue. Once the vcou is a sleep on a waitqueue it definitely
needs wake_up() to wake it.

Of course, p2m_mem_paging_resume() is quite likely the right place to put
the wake_up() call. But you do need it in addition to the unpause on the
MEM_EVENT flag.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel