Re: [Xen-devel] [PATCH, RFC, v2] qemu: build adjustments

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 19.11.10 at 19:25, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Jan Beulich writes ("[Xen-devel] [PATCH, RFC, v2] qemu: build adjustments"):
>> QEMU by itself can be built outside of its source directory. With the
>> qemu repository being separate from the hypervisor/tools one it seems
>> to make sense to make use of this feature, but doing so requires a
>> couple of adjustments to the Xen changes to it. Basically, if
>> CONFIG_QEMU is found to indicate an existing directory, this directory
>> will be used rather than cloning the git repo into the build tree.
>> 
>> The patch contains QEMU and tools/stubdom changes together for the
>> moment (with QEMU supposed to be residing in qemu/). For applying
>> this would need to be split.
> 
> I tried this with
>   (make -j4 KERNELS='' && echo ok.) 2>&1 | tee ../log
> and got a compiler error:
> 
> make[3]: *** No rule to make target 
> `/u/iwj/work/1/qemu-iwj.git/i386-stubdom/hookstarget.mak'.  Stop.
> 
> My .config says:
> 
> CONFIG_QEMU=/u/iwj/work/1/qemu-iwj.git
> 
> and that directory is a git checkout of qemu-xen with the qemu half of
> your patch applied.

That's *very* odd, as the patch adds this very file:

 qemu/Makefile.target                         |    9 +++++----
 qemu/i386-dm/hooks.mak                       |    2 +-
 qemu/i386-dm/hookstarget.mak                 |    2 +-
 qemu/i386-stubdom/hooks.mak                  |    2 +-
 qemu/i386-stubdom/hookslib.mak               |    1 +
 qemu/i386-stubdom/hookstarget.mak            |    1 +
 qemu/xen-config-host.mak                     |    6 +++---
 qemu/xen-config.mak                          |    1 +
 qemu/xen-hooks.mak                           |    2 +-
 qemu/xen-setup                               |   12 ++++++------
 qemu/xen-setup-stubdom                       |   18 +++++++++---------
 stubdom/Makefile                             |   14 ++++++++++++--
 tools/Makefile                               |   17 ++++++-----------
 13 files changed, 48 insertions(+), 39 deletions(-)

Could you double check your tree and the way you split the patch?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel