Re: [Xen-devel] [PATCH] stubdom: allow building with read-only sources

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 10.11.10 at 20:09, Patrick Colp <pjcolp@xxxxxxxxx> wrote:
>>  --- a/stubdom/Makefile
>> +++ b/stubdom/Makefile
>> @@ -155,8 +175,9 @@ cross-libpci: $(LIBPCI_STAMPFILE)
>>  $(LIBPCI_STAMPFILE): pciutils-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) 
> $(ZLIB_STAMPFILE)
>>        ( cd $< && \
>>          cp ../libpci.config.h lib/config.h && \
>> +         chmod u+w lib/config.h && \
>>          echo '#define PCILIB_VERSION "$(LIBPCI_VERSION)"' >> lib/config.h 
>> && \
>> -         cp ../libpci.config.mak lib/config.mk && \
>> +         ln -sf ../../libpci.config.mak lib/config.mk && \
> 
> Should the above line be
> 
>  +         ln -sf ../libpci.config.mak lib/config.mk && \
> 
> instead? It seems an extra ../ was added and based just on the patch I
> can't tell why.

No - the difference is between referencing the real file (cp) and
creating a relative (to the target's location) symlink.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel