[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fix ia64 tools build


  • To: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Fri, 29 Oct 2010 08:55:31 +0100
  • Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 29 Oct 2010 00:56:45 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=ZTB+KclugP7GvhY8D/lkiXtrDxwA28QBbt8gTPX+f1W/qKcxLBuW2fpeD+x8CA408k XZnZfHq/b4WjQzFXx8C6/ZWE0RB8V5UGhNxJqx1WixWP9C+0bj4u37stT4sxrrGENvIS vPhwUWl05gYwPHKfbFXsD+lx16afIGI45v7xc=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Act3PqiRtbSvWXUvGEOeMMExfeq9Aw==
  • Thread-topic: [Xen-devel] [PATCH] Fix ia64 tools build

On 29/10/2010 08:39, "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx> wrote:

> Ping?
> 
> This patch is still required for ia64 tools.
> 
> Best regards,

I think it would ne neater to have your own
tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from
Xen's acenv.h (e.g., dependent on __XEN_TOOLS__). Or revert the bits of c/s
22066 that broke the ia64 build in the first place -- possibly the changes
were based on a false assumption? Cc'ing the author of that patch, Ian
Campbell. In any case, ifdef'ing the bulk of aclinux.h is just gross, I
don't like that fix.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.