[Xen-devel] RE: [RFC][PATCH][VTD][v4] consolidate VT-d quirks into a single file quirks.c

["Kay, Allen M" <allen.m.kay@xxxxxxxxx>]

> Yes, this looks better now. However, map_igd_reg() now returns
> "status" without ever initializing the variable. Didn't the compiler
> warn (and the build fail because) of that? I think the function has
> no need to return non-void anymore.

I just did a build again, the compiler come with FC12 did not complain about it 
at all.  I have changed the function to void.

> The non-void return value of cantiga_vtd_ops_preamble() also
> looks bogus, btw.

The return value is not important in this case.  It is the requirement of the 
errata workaround to read the MMIO register.

> One thing I may not have noticed in earlier versions is your use
> of IGD_BAR_MASK - you define it as 0xFFFF0000 but then use
> it to mask a 64-bit value (i.e. cutting of the top 32 bits).

Fixed.

See attached for version 4.

Allen

Attachment: quirks1028.patch
Description: quirks1028.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel