[Xen-devel] Re: [PATCH]: libxl: fix dom0 minimum memory threshold check

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Fri, 2010-10-22 at 15:04 +0100, Stefano Stabellini wrote:
> On Fri, 22 Oct 2010, Gianni Tedesco wrote:
> > libxl_set_memory_target tries to set the memory target for a given
> > domain to new_target_memkb. The function includes a check to make sure
> > that dom0's memory is not reduced below a minimal threshold ie.
> > LIBXL_MIN_DOM0_MEM. However, this check is performed before the
> > new_target_memkb variable is properly initialised - when the value is
> > always zero. This means that the check always fails. Fix this by moving
> > the test to happen after the proper initialisation of new_target_memkb.
> > 
> > Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> > 
> 
> I wonder what caused this block misplacement, maybe patch or hg import?
> Anyway:

FWIW, I blame hg, I've seen it do similar things before!

Gianni



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel