Re: [Xen-devel] [PATCH] xen: do not unmask disabled IRQ on eoi.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 22 Oct 2010, Jan Beulich wrote:
> >>> On 21.10.10 at 15:36, Stefano Stabellini 
> >>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > New version of this patch:
> 
> Looks consistent now, with one possible exception (I'm not sure here
> really). I'm not going to ack this nevertheless as I continue to not be
> convinced of the switch to handle_edge_irq(), the more that your
> patch (as you write yourself) complicates the code.

In general I am always for the simplest solution, however in this case
it is not only a matter of simplicity but also a matter of correctness
and integration with the rest of linux irq handling infrastructure.

Obviously if something in this patch is inconsistent we could get less
correct and more complicated code so thanks for helping out making sure
it is consistent! If you find any more flaws please let me know :)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel