Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and library changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2010-10-12 at 10:51 +0100, Ian Jackson wrote:
> Juergen Gross writes ("[Xen-devel] [PATCH 2 of 3] support of cpupools in xl: 
> commands and library changes"):
> > tools/libxl/libxlu_cfg_l.c   |   30 --
> > tools/libxl/libxlu_cfg_l.h   |   18 -
> 
> I see you reran flex.  That's not wrong, but we shouldn't change these
> files needlessly, and you didn't make any changes to the .l source
> file, so when we apply this patch we should drop the changes to
> *_l.[ch].
> 
> > Renamed all cpu pool related names to *cpupool*
> 
> Is that really true in this patch ?  The function names and subcommand
> names in xl are still all "pool-*" and "pool_*".

The subcommands names are the xm names, which I thought we needed to
keep for compatibility.

We could add both cpupool- and pool- variants and deprecate the later.
Or perhaps these commands are not widely used (at least from scripts and
whatnot) and we can just change the name.

See <4CAB2CE5.1070208@xxxxxxxxxxxxxx> and
<1286371053.23155.12762.camel@xxxxxxxxxxxxxxxxxxxxxx> for some previous
discussion.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel