[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and library changes


  • To: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Fri, 08 Oct 2010 10:41:07 +0200
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 08 Oct 2010 01:41:53 -0700
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=DKhi4Xc+Gt7/+9N9qKetXliWtjFbBPeYpIl/rZbRiV+9RtP4hDSrNFpD 5D3x/Vd7hyTtZ+KSHw91yLCvmLkHAPGkl5sn00piq/TsYhvKDZFlDzhzi zMxYjS/X7ijMeciI0PTBMjaCCfBV0vuJxRkWIIF3auKtw+4JA5cJR5xvd gOmqqi0v0GaneowhNWolKkeA0Y0ENsycUNb2w4HkfkiF9WJKSHjvQth3V lX0Ht/6swx/FKyebHehrZQ3ipp2bf;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 10/06/10 15:47, Gianni Tedesco wrote:
On Tue, 2010-10-05 at 14:45 +0100, Juergen Gross wrote:
diff -r cfce8e755505 -r baee85a24411 tools/python/xen/lowlevel/xl/xl.c
--- a/tools/python/xen/lowlevel/xl/xl.c Tue Oct 05 14:19:13 2010 +0200
+++ b/tools/python/xen/lowlevel/xl/xl.c Tue Oct 05 15:26:24 2010 +0200
@@ -208,6 +208,11 @@
      return -1;
  }

+int attrib__uint64_t_ptr_set(PyObject *v, uint64_t * *pptr)
+{
+    return -1;
+}
+
  int attrib__libxl_cpumap_set(PyObject *v, libxl_cpumap *pptr)
  {
      return -1;
@@ -254,6 +259,11 @@
  }

  PyObject *attrib__libxl_cpuid_policy_list_get(libxl_cpuid_policy_list
*pptr)
+{
+    return NULL;
+}
+
+PyObject *attrib__uint64_t_ptr_get(uint64_t * *pptr)
  {
      return NULL;
  }

Because of using Reference(Uint64) directly in the idl - the python
bindings autogenerate these type-marshalling functions. It's not quite
clear how these are supposed to be implemented in a generic way! :)

There ought to be a builtin type for this ala libxl_uuid and other types
to generate correct bindings.

Gianni, I suppose I need a builtin for the complete libxl_cpumap type, not
only for the uint64_t array due to the size info which is needed to access
the array correctly.
I'm not sure how to translate this into the correct bindings. I think the
cpumap should be translated into a python list. Which methods do I need to
include in xc.c? Or would it be okay to add just some minimal dummy
functions and put in the functionality if needed?


Juergeb

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.