Re: [Xen-devel] [PATCH 1 of 3] To be able to support arbitrary numbers of physical cpus it was necessary to

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 5 Oct 2010, Juergen Gross wrote:
> diff -r fe3018c6976d -r cfce8e755505 tools/libxl/libxl_internal.h
> --- a/tools/libxl/libxl_internal.h    Mon Oct 04 12:52:14 2010 +0100
> +++ b/tools/libxl/libxl_internal.h    Tue Oct 05 14:19:13 2010 +0200
> @@ -239,7 +239,6 @@
>  _hidden char *libxl__domid_to_name(libxl__gc *gc, uint32_t domid);
>  _hidden char *libxl__poolid_to_name(libxl__gc *gc, uint32_t poolid);
>  
> -
>    /* holds the CPUID response for a single CPUID leaf
>     * input contains the value of the EAX and ECX register,
>     * and each policy string contains a filter to apply to

we don't need this change


> diff -r fe3018c6976d -r cfce8e755505 tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c        Mon Oct 04 12:52:14 2010 +0100
> +++ b/tools/libxl/xl_cmdimpl.c        Tue Oct 05 14:19:13 2010 +0200
> @@ -3616,12 +3616,11 @@
>  static void vcpupin(char *d, const char *vcpu, char *cpu)
>  {
>      libxl_vcpuinfo *vcpuinfo;
> -    libxl_physinfo physinfo;
>      uint64_t *cpumap = NULL;
>  
>      uint32_t vcpuid, cpuida, cpuidb;
>      char *endptr, *toka, *tokb;
> -    int i, nb_vcpu, cpusize;
> +    int i, nb_vcpu, cpusize, cpumapsize;
>  
>      vcpuid = strtoul(vcpu, &endptr, 10);
>      if (vcpu == endptr) {
> @@ -3634,12 +3633,13 @@
>  
>      find_domain(d);
>  
> -    if (libxl_get_physinfo(&ctx, &physinfo) != 0) {
> -        fprintf(stderr, "libxl_get_physinfo failed.\n");
> +    if ((cpusize = xc_get_max_cpus(ctx.xch)) == 0) {
> +        fprintf(stderr, "xc_get_maxcpus failed.\n");
>          goto vcpupin_out1;
>      }

You shouldn't be calling xc functions directly from xl_cmdimpl.c.
The basic rule is: libxl clients (such as xl) shouldn't need to call any
library functions other than libxenlight's functions.
You can add a libxl_get_max_cpus function though.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel