Re: [Xen-devel] [xen-unstable test] 2315: regressions - FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2010-10-04 at 02:18 +0100, xen.org wrote:
> flight 2315 xen-unstable real
> http://www.chiark.greenend.org.uk/~xensrcts/logs/2315/
> 
> Regressions :-(
> 
> tests which did not succeed:
>  build-i386-oldkern            1 xen-build                  fail REGR. vs. 
> 2132
>  build-i386                    3 xen-build                  fail REGR. vs. 
> 2132

Subject: fix build on 32 bit

cc1: warnings being treated as errors
common.c:2783: error: 'sh_clear_up_pointer' defined but not used
make[6]: *** [common.o] Error 1
make[6]: Leaving directory 
`/home/osstest/build.2315.build-i386/xen-unstable/xen/arch/x86/mm/shadow'
make[5]: *** [shadow/built_in.o] Error 2
make[5]: Leaving directory 
`/home/osstest/build.2315.build-i386/xen-unstable/xen/arch/x86/mm'
make[4]: *** [mm/built_in.o] Error 2
make[4]: *** Waiting for unfinished jobs....

sh_clear_up_pointer is only used if CONFIG_PAGING_LEVELS >= 4

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 5f2f8b84b2ac xen/arch/x86/mm/shadow/common.c
--- a/xen/arch/x86/mm/shadow/common.c   Mon Oct 04 11:27:40 2010 +0100
+++ b/xen/arch/x86/mm/shadow/common.c   Mon Oct 04 11:29:20 2010 +0100
@@ -2776,6 +2776,7 @@ sh_remove_all_shadows_and_parents(struct
 
 /**************************************************************************/
 
+#if CONFIG_PAGING_LEVELS >= 4
 /* Reset the up-pointers of every L3 shadow to 0. 
  * This is called when l3 shadows stop being pinnable, to clear out all
  * the list-head bits so the up-pointer field is properly inititalised. */
@@ -2784,6 +2785,7 @@ static int sh_clear_up_pointer(struct vc
     mfn_to_page(smfn)->up = 0;
     return 0;
 }
+#endif
 
 void sh_reset_l3_up_pointers(struct vcpu *v)
 {




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel