[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] no cycles for certain xentrace entries


  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Wed, 29 Sep 2010 10:09:29 +0200
  • Delivery-date: Wed, 29 Sep 2010 01:10:34 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On Tue, Aug 31, Olaf Hering wrote:

> what is the reason for the empty tsc for some xentracing calls, like
> TRC_HVM_IOPORT_READ?
> It makes sorting the resulting logfile by tsc value difficult because
> the 0 entries end up at the beginning of the logfile.

This change appears to work for me.
So, what is the reason for the cycles parameter to trace_var()?

--- xen-4.0.1-testing.orig/xen/common/trace.c
+++ xen-4.0.1-testing/xen/common/trace.c
@@ -631,6 +631,7 @@ void __trace_var(u32 event, bool_t cycle
     if( !tb_init_done )
         return;

+    cycles = 1;
     /* Convert byte count into word count, rounding up */
     extra_word = (extra / sizeof(u32));
     if ( (extra % sizeof(u32)) != 0 )



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.