Re: [Xen-devel] libxl: xl create segfaults

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Thu, 2010-09-23 at 11:27 +0100, Christoph Egger wrote:
> Hi!
> 
> 'xl create' crashes due to stack corruption.

---8<-------------------------------------------

xl: Fix stack corruption caused by non-terminated call to libxl__xs_writev

Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>

diff -r 50c1cc209f8f tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Wed Sep 22 18:29:24 2010 +0100
+++ b/tools/libxl/libxl.c       Thu Sep 23 16:54:09 2010 +0100
@@ -1718,7 +1718,7 @@ retry_transaction:
         vm_path = libxl__xs_read(&gc,t,libxl__sprintf(&gc, "%s/vm", 
p->dom_path));
         if (vm_path) {
             /* Now write the vncpassword into it. */
-            pass_stuff = libxl__calloc(&gc, 2, sizeof(char *));
+            pass_stuff = libxl__calloc(&gc, 3, sizeof(char *));
             pass_stuff[0] = "vncpasswd";
             pass_stuff[1] = info->vncpasswd;
             libxl__xs_writev(&gc,t,vm_path,pass_stuff);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel