[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [Patch] support of cpu pools in xl


  • To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Mon, 20 Sep 2010 06:58:54 +0200
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
  • Delivery-date: Sun, 19 Sep 2010 21:59:47 -0700
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=V6qR5gX5Z0eZSxUJ9nHb5AktW5UqIQTuu4PA/5mpMzeh/8eub0rQIBoN M6jK7pjJG/UTR40ccWuTjqIZ01XdJ5bqCp/kHV6dEVbNBx/Q6gkAsXvdv bBHUzf65nYTzRuGm0pAMWhnqJPhf4QLfsvfOzc2wNV0yoTcGmSTWXsNyN q98oOiwXpIANDhXQvqP3878StWHnYfS4i8gK+2+ki1fC+3kw5GcWg51TN us/3JwmmlQ/cmhkIjR44MOflna8jg;
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 09/17/10 20:28, Ian Campbell wrote:
On Fri, 2010-09-17 at 16:53 +0100, Ian Jackson wrote:
Ian Campbell writes ("Re: [Xen-devel] Re: [Patch] support of cpu pools in xl"):
On Fri, 2010-09-17 at 12:41 +0100, Juergen Gross wrote:
I just wanted to be able to support some (inactive) cpupools without any
cpu allocated. It's just a number which should normally be large enough.

What is the purpose of these inactive cpupools?

Amongst other things, I would guess, the creation or removal of
cpupools !

"Inactive cpupools" were meant to be cpupools without any cpus and domains
assigned to them.
They can exist for a short time during creation and removal, but due to
explicitly removing all cpus, too.

I don't think so, libxl_create_cpupool returns a new poolid for a newly
created pool, so they are not needed for that.

They have a poolid, but there might be more cpupools than cpus in the system.
This was the reason for the "+ 32". But I agree, this should be done via a
#define.

BTW I noticed that we have libxl_list_pool vs
libxl_{create,destroy}_cpupool and
libxl_cpupool_{cpuadd,cpuremove,movedomain}. I think the interface
should use cpupool throughout and not just pool to make it clear what it
is a pool of. IOW libxl_list_pool should be libxl_list_cpupool, the type
should be called  libxl_cpupool and functions such as
libxl_name_to_poolid should instead be libxl_name_to_cpupoolid.

Okay, I'll change it.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.