RE: [Xen-devel] [PATCH 15/16] vmx: nest: capability reporting MSRs

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

Christoph Egger wrote:
> On Wednesday 08 September 2010 17:22:23 Qing He wrote:
>> handles VMX capability reporting MSRs.
>> Some features are masked so L1 would see a rather
>> simple configuration
>> 
>> Signed-off-by: Qing He <qing.he@xxxxxxxxx>
>> Signed-off-by: Eddie Dong <eddie.dong@xxxxxxxxx>
> 
> 
> Are there any vmx capability features that are read out via cpuid ?
> If yes, then that code belongs into the tools patch.

That is in 16.txt, you can include in your code. Once you fixed the MAX LEAF 
issue, I can ack that patch.

> 
> In SVM the nestedhvm_vcpu_features hook is empty and for MSRs
> there are already two msr hooks namely msr_read_intercept and
> msr_write_intercept. I assume the functions below all called from
> there directly or indirectly.

No. this interception is for L1 guest. 

> 
> That renders the nestedhvm_vcpu_features hook useless and will remove
> it. 

A step toward my wish of light weight wrapper, glad to see! The more you 
removed, the more I can ack, untill the point only those necessary APIs were 
left, such as nested EPT/NPT, heavily revisited interrupt injection API after 
removing the new namespace.

Thx, Eddie
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel