RE: [Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

>> It's not like you're defining
>> namespaces for new abstractions you have conjured from thin air --
>> they correspond directly to a hardware-defined decode format.
>> Defining enumerations on top of that is *good*, imo. I would take
>> 06/16 as it stands. 
> 
> Fair enough, but I'd like the memory leak fixed too (svmcs and vvmcs
> are only freed if the N1 guest executes VMXOFF).
> 
Sure. Fixed it locally at vmx_destroy_vmcs.

BTW, how do you like CONFIG_VVMCS_MAPPING ? I feel a little bit more 
complicated.

And how about rename vvmcs to vmcs12 (VMCS used by L1 VMM for L2 guest), and
rename svmcs as vmcs02 (VMCS used by L0 VMM for L2 guest).
Of course hvmcs becomes vmcs01 then, (VMCS used by L0 VMM for L1 guest).

Thx, Eddie
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel