Re: [Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 08:05 +0100 on 10 Sep (1284105901), Dong, Eddie wrote:
> Qing He wrote:
> > +static int __clear_current_vvmcs(struct vmx_nest_struct *nest)
> > +{
> > +    int rc;
> > +
> > +    if ( nest->svmcs )
> > +        __vmpclear(virt_to_maddr(nest->svmcs));
> > +
> > +#if !CONFIG_VVMCS_MAPPING
> > +    rc = hvm_copy_to_guest_phys(nest->gvmcs_pa, nest->vvmcs,
> 
> 
> Qing:
>       Why this may be failure? The only reason may be nest->gvmcs_pa, but I 
> guess we already verified the address.
> 

It was verified at load time, but the guest could have ballooned it out
in the meantime. 

Cheers,

Tim

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel