RE: [Xen-devel] [PATCH] Clear device-model information when destroying an HVM domain with stubdom-v3

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Jun Zhu (Intern) writes ("RE: [Xen-devel] [PATCH] Clear device-model 
information when destroying an HVM domain with stubdom-v3"):
> Thanks for your suggesion. I use goto out in both wrong condition,
> and remove the unnecessory logging. The vim tabs has been converted
> to 4 spaces.

Thanks.  You still need to put { and } on the same line as the else :-).

Also, more seriously:

> +        } else {
> +            XL_LOG_ERRNO(ctx, XL_LOG_ERROR, "failed to kill Device Model 
> [%d]",
> +                    atoi(pid));
> +            goto out;

This should set ret to something appropriate.  ERROR_FAIL, probably.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel