Re: [Xen-devel] [PATCH] xl: fix vcpu-set cmd line parsing

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

stefano.stabellini@xxxxxxxxxxxxx writes ("[Xen-devel] [PATCH] xl: fix vcpu-set 
cmd line parsing"):
> -    if (argc != 4) {
> -        help("vcpu-set");
...
> +    if (optind >= argc - 1) {
> +        help("vcpu-set");

I applaud your efforts to fix up the broken command-line parsing but
surely this can't be right ?  We need to have exactly two more
arguments, not at least two.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel