Re: [Xen-devel] [PATCH 1 of 8] libxl: Fix xcinfo2xlinfo to properly set max_memkb and target_memkb

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("[Xen-devel] [PATCH 1 of 8] libxl: Fix xcinfo2xlinfo 
to properly set max_memkb and target_memkb"):
> libxl: Fix xcinfo2xlinfo to properly set max_memkb and target_memkb
> 
> currently xcinfo2xlinfo reads tot_pages and uses that data to calculate
> max_memkb, while tot_pages is the memory currently used by the domain
> and max_pages is the theoretical maximum.

> +    xlinfo->target_memkb = PAGE_TO_MEMKB(xcinfo->tot_pages);

Um, I don't think this is right, is it ?  If "target" means "memory
target eg for domain balloon driver".

The memory target can be read only from xenstore.  But in general if
we are sane we always set the hypervisor's maximum to the same as the
ballooning target.  So I'm not sure having separate "max" and "total"
values visible to libxl callers is correct.  There two values visible
to libxl callers should be "target" and "current".

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel