RE: [Xen-devel] [PATCH] xl: obey uuid config option

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 26 Aug 2010, Owen Smith wrote:
> What should the behaviour be if the uuid config option is a valid string but 
> an invalid format?
> 

good point.
We need to check the return value of libxl_uuid_from_string and act
accordingly.

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Gianni Tedesco
> Sent: 25 August 2010 19:42
> To: Xen Devel
> Cc: Ian Jackson; Stefano Stabellini
> Subject: [Xen-devel] [PATCH] xl: obey uuid config option
> 
> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> 
> diff -r fd38d1c9f5ac tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c        Wed Aug 25 19:39:05 2010 +0100
> +++ b/tools/libxl/xl_cmdimpl.c        Wed Aug 25 19:44:33 2010 +0100
> @@ -607,7 +607,11 @@ static void parse_config_data(const char
>          c_info->name = strdup(buf);
>      else
>          c_info->name = "test";
> -    libxl_uuid_generate(&c_info->uuid);
> +
> +    if (!xlu_cfg_get_string (config, "uuid", &buf))
> +        libxl_uuid_from_string(&c_info->uuid, buf);
> +    else
> +        libxl_uuid_generate(&c_info->uuid);
>  
>      if (!xlu_cfg_get_long(config, "oos", &l))
>          c_info->oos = l;
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel