[Xen-devel] Re: you patch "block: push down BKL into .open and .release" and its changes to xen-blkfront.c

[Jens Axboe <jaxboe@xxxxxxxxxxxx>]

On 2010-08-25 12:59, Jan Beulich wrote:
> Arnd,
> 
> what was the point of adding {,un}lock_kernel() to blkif_open() and
> blkif_release()? Afaict, the associated bdev is protected by a mutex
> anyway, so even without Daniel's addition of a mutex to these
> paths I don't see the need for the BKL here.

I'll let Arnd answer for himself, but at least in general it's
much easier to let this sort of auditing and final cleanup
be done my the maintainer(s) of the driver in question, as they
are best positioned to verify that the BKL in fact isn't
really necessary in that path anymore.

-- 
Jens Axboe


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel