[Xen-devel] Re: [PATCH] VT-d: Hardware require RH bit to be set in IRTE when delivery mode is LPR

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 26/08/2010 10:17, "Sheng Yang" <sheng@xxxxxxxxxxxxxxx> wrote:

> +    /* Hardware require RH = 1 for LPR delivery mode */
> +    if ( new_ire.lo.dlm == dest_LowestPrio )
> +        new_ire.lo.rh = 1;
> +    else
> +        new_ire.lo.rh = 0;

The form 'if ( p ) x = 1; else x = 0;' is better written as 'x = (p)'.
Please re-submit in that style.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel