Re: [Xen-devel] [PATCH] libxl: make is_hvm log on errors, and make callers check its error returns

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Tue, 2010-08-24 at 14:40 +0100, Ian Jackson wrote:
> Gianni Tedesco (3P) writes ("Re: [Xen-devel] [PATCH] libxl: make is_hvm log 
> on errors,        and make callers check its error returns"):
> > I hate this coding style, it's really easy to miss whats going on when
> > scanning code and two things are done on one line. I think either lines
> > ought to be added or change declaration to:
> > 
> > int get_vm_mode(libxl_ctx, int domid, int *hvm);
> > 
> > so at least compiler can tell you if you're using it the way it was
> > intended.
> 
> I'd be happy with the latter proposal.  I don't like anything that
> increases the code size.  Shall I resend my patch ?

Fair enough, yes please re-send.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel