Re: [Xen-devel] [PATCH] xl: improve vif2 parsing

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Fri, 2010-08-20 at 13:03 +0100, Andre Przywara wrote:
> Andre Przywara wrote:
> > Hi,
> > 
> > vif2 parsing relies on counted strncmp() statements. Replace this
> > with a more robust automatic version.
> 
> No, I didn't want to leave this as an exercise to the reader, I am just
> spoiled by git send-email, so forgot to attach the patch. Sorry!
> 
> > 
> > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> >

Both patches look good to me.

> > Regards,
> > Andre.
> > 
> > P.S. If you like this, I have seen at least two more instances of the 
> > same issue that could be improved this way.
> > 

Can you say where?

You should be aware that disk config parsing is undergoing a rewrite
already so lets not duplicate efforts on that one ;)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel