Re: [Xen-devel] [PATCH] libxc: make unlock_page return error

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Wednesday 18 August 2010 18:05:40 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libxc: make unlock_page return 
error"):
> > As a result of debugging 'xend segfaults when starting',
> > the attached patch makes unlock_pages return an error.
>
> I'm not opposed to this general idea, but: you change unlock_pages to
> return an int but you don't seem to change any of its callers.

That's right. I leave this todo item to someone else.

> What is the point ?

In this shape it helps debugging problems like I do with Ian Campell.
It makes it easy to just add a debug output to print the error code.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel