[Xen-devel] Re: [PATCH] xl: make libxl_uuid2string internal to libxenlight

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Gianni Tedesco (3P) writes ("[PATCH] xl: make libxl_uuid2string internal to 
libxenlight"):
> libxenlight exports a function libxl_uuid2string which is used
> internally in several places but has one external caller in xl. The
> function mainly implements policy so should not be part of the
> libxenlight API. The extent to which it can be considered mechanism it
> is not a xen mechanism since UUID's are not a concept exlusive to xen.
> 
> The one caller in xl seems to be an "odd-one-out" since xl has its own
> UUID formatting macros in any case.

This is not a good idea because it duplicates code - even if it's just
the macros for formatting uuids.  How to format a UUID is not
"policy", it is a fact about UUIDs.

I see that xl already has some duplicated uuid formatting code.  This
should be removed, not extended.  One of the cardinal sins in
programming is duplicating code.

Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel