Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Jackson writes ("Re: [Xen-devel] [PATCH] add SONAME to libblktapctl.so"):
> That's a convincing explanation.  In which case, as regards your
> patch,
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> and we should have a separate changeset to remove -fPIC and -rdynamic.

And here that one is:


tools/blktap2: Remove unnecessary -fPIC and -rdynamic from link line

Where these options are needed they will be in the appropriate *FLAGS
variables; they should not appear in specific Makefiles.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


diff -r ddb9f47ef2e2 tools/blktap2/control/Makefile
--- a/tools/blktap2/control/Makefile    Thu Aug 12 18:56:20 2010 +0100
+++ b/tools/blktap2/control/Makefile    Fri Aug 13 13:34:49 2010 +0100
@@ -61,7 +61,7 @@ tap-ctl: tap-ctl.o $(LIBNAME).so
        $(AR) r $@ $^
 
 $(LIB_SHARED): $(CTL_PICS)
-       $(CC) $(CFLAGS) $(LDFLAGS) -fPIC  -Wl,$(SONAME_LDFLAG) -Wl,$(LIBSONAME) 
$(SHLIB_LDFLAGS) -rdynamic $^ -o $@
+       $(CC) $(CFLAGS) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,$(LIBSONAME) 
$(SHLIB_LDFLAGS) $^ -o $@
 
 install: $(IBIN) $(LIB_STATIC) $(LIB_SHARED)
        $(INSTALL_DIR) -p $(DESTDIR)$(SBINDIR)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel