Re: [Xen-devel] [PATCH 5 of 8] libxl: autogenerate _libxl_types.h

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Tue, 2010-08-03 at 12:00 +0100, Ian Campbell wrote:
> +Types = [
> +    libxl_dominfo,
> +    libxl_poolinfo,
> +    libxl_vminfo,
> +    libxl_version_info,
> +    libxl_domain_create_info,
> +    libxl_file_reference,
> +    libxl_domain_build_info,
> +    libxl_domain_build_state,
> +    libxl_device_model_info,
> +    libxl_device_vfb,
> +    libxl_device_vkb,
> +    libxl_device_console,
> +    libxl_device_disk,
> +    libxl_device_nic,
> +    libxl_device_net2,
> +    libxl_device_pci,
> +]

I like the idea of the patch, I think the libxl bits should be in a
separate python module though or perhaps the gentypes.py.

Also I think an integer ptr attribute on the base class would be a good
idea if only to get rid of nasty whitespace issue :) -- I haven't groked
the code too closely but it may also be able to fold such a thing in to
has_destructor attribute? anyway...


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel