Re: [Xen-devel] [PATCH] libxl: Allow PV guests to add a PCI device without an IOMMU

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Mihir Nanavati writes ("[Xen-devel] [PATCH] libxl: Allow PV guests to add a PCI 
device without an IOMMU"):
> Added a check which allows adding and removal of PCI devices for PV
> guests in the absence of an IOMMU

+        if (rc < 0 && (hvm || ENOSYS != errno)) {
                               ^^^^^^^^^^^^^^^^
Nowadays we have compilers which spot the mistake that this
unnatural and hard-to-read idiom is intended to avoid.

As to the substance I'm not sure I'm confident that it's right ...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel