Re: [Xen-devel] [PATCH] libxl: move blktap specific code into libxl_blktap.c

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("[Xen-devel] [PATCH] libxl: move blktap specific code 
into libxl_blktap.c"):
> Move blktap specific code into libxl_blktap.c

Thanks, this is going in the right direction.  But can you please
split up the moving code into a different file, from the changes to
that code ?

As it is it is almost impossible to see what changes you have made to
the code you are moving, as we have

 diff old-file
   stuff
 - old
 - code
   more stuff
 diff new-file
 + newly
 + reorganised
 + code


If the code needs to be reorganised so that it can be moved, you
should do this in two patches, so we end up with:

 [PATCH 1/2] reorganise preparatory to moving

 diff old-file
   stuff
 - old
 + newly
 + reorganised
   code
   more stuff

 [PATCH 2/2] move blktap-specific code to libxl_blktap.c
 Purely moving code about, no changes.

 diff old-file
   stuff
 - newly
 - reorganised
 - code
   old stuff
 diff new-file
 + newly
 + reorganised
 + code


Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel