Re: [Xen-devel] [PATCH 2 of 3] xl, implement pci-list-assignable-devices

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Tue, 2010-07-27 at 17:24 +0100, Gianni Tedesco wrote:
> +                bdf = libxl_xs_read(ctx, XBT_NULL, devpath);
> +                if ( bdf ) {
> +                    unsigned dom, bus, dev, func;
> +                    if ( sscanf(bdf, PCI_BDF, &dom, &bus, &dev, &func) != 4 )
> +                        continue;
> +
> +                    new = realloc(pcidevs, ((*num) + 1) * sizeof(*new));
> +                    if ( NULL == new )
> +                        continue;
> +
> +                    pcidevs = new;
> +                    new = pcidevs + *num;
> +
> +                    libxl_device_pci_init(new, dom, bus, dev, func, ~0);
> +                    (*num)++;
> +                }

Please don't apply patch 2 and therefore 3 from this set. This part is
erroneous. Fixed in my tree and will submit the latest batch of updates
soon.

Thanks


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel