Re: [Xen-devel] [PATCH 5/6] libxl: portiblity fixes

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("[Xen-devel] [PATCH 5/6] libxl: portiblity fixes"):
>  LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o
> +LIBXL_OBJS-$(CONFIG_Linux) += libxl_linux.o
> +LIBXL_OBJS-$(CONFIG_NetBSD) += libxl_netbsd.o

As previously discussed, these files should probably be called
libxl_blktap2.c and libxl_noblktap2.c or some such.

> +const char *libxl_blktap_devpath(struct libxl_ctx *ctx,
> +                                 const char *disk,
> +                                 libxl_disk_phystype phystype)

You seem to be moving code about by adding it in one patch and
deleting it in another; as I mentioned before, that's not the right
thing to do.

When submitting a patch series, every individual patch should make
sense by itself and leave a sane and compilable tree.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel