[Xen-devel] [PATCH] [xend] fix coredump-{restart, destroy} on_crash actions

[Jim Fehlig <jfehlig@xxxxxxxxxx>]

After all of these years, more fallout from xen-api and legacy xmlrpc
integration.  Can't say I'll miss xend :-).

Please apply to xen-4.0-testing.

Regards,
Jim


# HG changeset patch
# User Jim Fehlig <jfehlig@xxxxxxxxxx>
# Date 1280165174 21600
# Node ID 3da5c666fb1ba1f532803e59040e7a0d8481c2ba
# Parent  ac7e4c6ec6c7494e4046da92aa8f62f6c1371438
The xm documentation and example config files state that possible
"on crash" behaviors include coredump-{restart,destroy},
but domain creation will fail if either of these options are
specified

xen52:~ # grep coredump /etc/xen/vm/test
on_crash="coredump-restart"
xen52:~ # xm create /etc/xen/vm/test
Using config file "/etc/xen/vm/test".
Error: Invalid argument.

coredump-and-{restart,destroy} are permissible but unnecessarily
verbose and inconsistent with documentation.  This patch simply
adds coredump-{restart,destroy} to the list of permissible values.

    Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>

diff -r ac7e4c6ec6c7 -r 3da5c666fb1b tools/python/xen/xend/XendAPIConstants.py
--- a/tools/python/xen/xend/XendAPIConstants.py Fri Jul 23 19:23:49 2010 +0100
+++ b/tools/python/xen/xend/XendAPIConstants.py Mon Jul 26 11:26:14 2010 -0600
@@ -45,8 +45,10 @@
 XEN_API_ON_CRASH_BEHAVIOUR = [
     'destroy',
     'coredump_and_destroy',
+    'coredump_destroy',
     'restart',
     'coredump_and_restart',
+    'coredump_restart',
     'preserve',
     'rename_restart'
 ]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel