[Xen-devel] Re: [PATCH] Introduce dom0-min-space configuration option

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On 07/26/2010 08:55 AM, Michal Novotny wrote:
> Or do you think that we should alter the message in gunzip function to
> say that there's an error in data stream (premature end of data stream)
> and that user should check for enough space on dom0?
No, the gunzip function (in libxc, if I understood the context) should 
not even be called if pygrub could not write the file.  Instead, it 
should print something like
pygrub: No space left on device

and exit.  There's absolutely no error checking here:

    data = fs.open_file(chosencfg["kernel"]).read()
    (tfd, bootcfg["kernel"]) = tempfile.mkstemp(prefix="boot_kernel.",
        dir="/var/run/xend/boot")
    os.write(tfd, data)
    os.close(tfd)

(and likewise for initrd) and that's the bug.

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel