Re: [Xen-devel] [PATCH,RFC] More consistent error handling in libxl

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Gianni Tedesco writes ("[Xen-devel] [PATCH,RFC] More consistent error handling 
in libxl"):
> +    int rc;
> +    rc = xc_domain_pause(ctx->xch, domid);
> +    return libxl_xc_error(rc);

I'm afraid this pattern is wrong for two reasons.  Firstly,
xc_domain_pause and functions like it do not return XC_ERROR_* values.
They typically return -1 on error, and set errno.

Secondly, the error codes from libxc are not really all that useful.
They mostly serve to identify where the error originated.

See the comment in xenctrl.h near line 70.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel