Re: [Xen-devel] [PATCH] hg ignore libxl lex/yacc detritus

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Keir Fraser writes ("Re: [Xen-devel] [PATCH] hg ignore libxl lex/yacc 
detritus"):
> Changeset 21000 checked those files into the tree, so adding them to
> .hgignore would be very bad form. I've missed checking in bits of patches
> due to that before.

Quite.

> If they are getting modified (i.e., regenerated) as part of your build then
> that is a bug. Possibly the rules to generate them should be commented out
> in the checked-in Makefile in that case... Whatever, I leave it to Stefano
> and Ian to make a decision on that. But the right patch won't touch
> .hgignore.

They should be regenerated if the corresponding input files
(libxlu_cfg.l and libxlu_cfg.y) have changed.  I think make will avoid
rebuilding them if they haven't.  So the make lines shouldn't be
commented out.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel