Re: [Xen-devel] [PATCH] x86: optimize this_cpu()

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 13/07/2010 15:26, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> That's just nasty. If we need the structure to be 16-byte aligned then we
> should achieve it via __attribute__((__aligned__(16))). And if we add that
> we may as well not ifdef it, I'm sure the up to 12 bytes padding on i386
> won't cause stack overflow.

I should add: if you agree please re-do the patch. Also a code comment on
what the alignment attribute is for would be a good idea of course.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel