Re: [Xen-devel] [PATCH] Serialise some things in top-level Makefile

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Tim Deegan writes ("Re: [Xen-devel] [PATCH] Serialise some things in top-level 
Makefile"):
> +1.  I do most of my work with 32-bit tools and a 64-bit Xen; I
> definitely don't want to serialize my tools builds behind a useless
> 32-bit Xen build.

You all seem to be right that "make tools" works without "make xen".
I had a clear impression that the reverse was true.  It doesn't seem
to be any more.

"make stubdom" doesn't work on its own though.  So how about this ?


Makefile: Serialise stubdom build after tools

Currently "make stubdom" on its own fails because it depends on files
being installed by the results of "make tools".  This also means that
in some circumstances a parallel "make tools stubdom" (or "make all")
can fail due to races.  So make "make stubdom" depend on "make tools"
having completed first.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


diff -r a0f0ae5be814 Makefile
--- a/Makefile  Tue Jul 06 17:58:37 2010 +0100
+++ b/Makefile  Thu Jul 08 15:08:08 2010 +0100
@@ -74,7 +74,7 @@
        for i in $(XKERNELS) ; do $(MAKE) $$i-install || exit 1; done
 
 .PHONY: install-stubdom
-install-stubdom: tools/ioemu-dir
+install-stubdom: tools/ioemu-dir install-tools
        $(MAKE) -C stubdom install
 ifeq (x86_64,$(XEN_TARGET_ARCH))
        XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom install-grub


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel