Re: [Xen-devel] [PATCH] hotplug script: lock directory remains on error

[Kouya Shimura <kouya@xxxxxxxxxxxxxx>]

> > Adding sigerr is extra.
> 
> I'm not sure I follow this.  Why is this a good idea ?  Why not just
> say "exit 1" in the error handler in this script ?

Please see xen-hotplug-common.sh. Original (redefined) sigerr function
writes some error status to the xenstore.

On the other hand, the network-bridge script also includes locking.sh.
But sigerr function is not defined in it. Actually I met
"sh: sigerr: command not found" message on executing the network-bridge
script. Thus, I defined it in locking.sh, too.

Thanks,
Kouya

Ian Jackson writes:
> Kouya Shimura writes ("[Xen-devel] [PATCH] hotplug script: lock directory 
> remains on error"):
> > _release_lock should be used instead of release_lock.
> 
> That part is OK.
> 
> > Adding sigerr is extra.
> 
> I'm not sure I follow this.  Why is this a good idea ?  Why not just
> say "exit 1" in the error handler in this script ?
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel