Re: [Xen-devel] [PATCH] x86 oprofile: use rdmsrl/wrmsrl

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 30/06/2010 11:12, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> On Tuesday 29 June 2010 18:02:54 Keir Fraser wrote:
>> How many more of these patches do you have up your sleeve?
> 
> Depends on how small/large the chunks should/may be.
> My intention is to remove duplicated rdmsr/wrmsr functions
> and make rdmsr usable as a real C function.

It's a lot of effort for questionable value isn't it. And many of your
patches so far have contained bugs, and in some cases decreased code
readability by needing to manually merge/split values to be able to make use
of rdmsrl/wrmsrl, so it's not like it's even strictly improving the code.
Frankly, it smells like busy work.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel