[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge
Isaku, Thanks for the feedback. > pci_{read, write}_block() would be better than > switch(len) case 1: case 2: case4:... Done! > Is it really necessary to move PCIBus and PCIBridge to the header file? > Doesn't pci_bridge_init() work? I changed to code to utilize pci_bridge_init(). However, I still need to move PCIBus and PCIBridge defines to the header file. The alternative is to pollute pc.c with graphics passthrough specific code. > Overriding pci config read/write methods of i440fx would be much cleaner > than hooking pci_data_read/write. (pass igd_pci_read/write to > pci_register_device() in i440fx_init() in hw/piix_pci.c instead of NULL) Doing this resulted in a lot of duplicated code and also force code path to change even when IGD passthrough is not used. To do it correctly, I also need to put in IGD or PASSTHROGH awareness in piix_pci.c. For now, I'm going to keep the original patch. Allen _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |